[compiler-rt] r184734 - [msan] Unpoison param-tls in signal handler wrapper.

[Evgeniy Stepanov]

Thanks!

On Thu, Jun 27, 2013 at 11:52 AM, Alexey Samsonov <samsonov at google.com> wrote:
> I think this should be fixed by r185062. Thanks!
>
>
> On Thu, Jun 27, 2013 at 2:57 AM, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> On Mon, Jun 24, 2013 at 6:48 AM, Evgeniy Stepanov
>> <eugeni.stepanov at gmail.com> wrote:
>> > Author: eugenis
>> > Date: Mon Jun 24 08:48:42 2013
>> > New Revision: 184734
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=184734&view=rev
>> > Log:
>> > [msan] Unpoison param-tls in signal handler wrapper.
>>
>> Not sure if this is related to this commit, but gold seems to be
>> warning about __msan_unpoison_param:
>>
>> /bin/ld: warning: Cannot export local symbol '__msan_unpoison_param'
>>
>> >
>> > This an entry point from uninstrumented code.
>> >
>> > Modified:
>> >     compiler-rt/trunk/lib/msan/msan_interceptors.cc
>> >
>> > Modified: compiler-rt/trunk/lib/msan/msan_interceptors.cc
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/msan/msan_interceptors.cc?rev=184734&r1=184733&r2=184734&view=diff
>> >
>> > ==============================================================================
>> > --- compiler-rt/trunk/lib/msan/msan_interceptors.cc (original)
>> > +++ compiler-rt/trunk/lib/msan/msan_interceptors.cc Mon Jun 24 08:48:42
>> > 2013
>> > @@ -888,6 +888,7 @@ static void SignalHandler(int signo) {
>> >  }
>> >
>> >  static void SignalAction(int signo, void *si, void *uc) {
>> > +  __msan_unpoison_param(3);
>> >    __msan_unpoison(si, __sanitizer::struct_sigaction_sz);
>> >    __msan_unpoison(uc, __sanitizer::ucontext_t_sz);
>> >
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
>
> --
> Alexey Samsonov, MSK