[llvm] r184932 - Suppress llvm/test/Other/can-execute.txt on msys bash.

[NAKAMURA Takumi]

Rafael,

I noticed this could be suppressed anyways on win32, at last.
At a glance, I didn't investigate what was the real problem.

They are issues;

- MSYS is not affected to mark as +x. "chmod 111" is simply drop write
bits. MSYS detects virtual +x bits to inspect the file.
- Lit on python/win32 doesn't transform %T to msys-compatible form,
for example /e/path/to/test/Output.
  I don't think it would be a good idea to transform %paths to let this passed.
- utils/not doesn't assume to run shell script on win32.

I suppose there might be other issues. That said, I assume this
doesn't make sense to run this on msys bash anyways.

I don't oppose to rename the feature "can-execute" ;)
Thanks!

FYI, Cygwin can run this. It's an emulator.

...Takumi

2013/6/27 Rafael Espíndola <rafael.espindola at gmail.com>:
> What was the problem msys?
>
> On 26 June 2013 06:56, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>> Author: chapuni
>> Date: Wed Jun 26 05:56:44 2013
>> New Revision: 184932
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=184932&view=rev
>> Log:
>> Suppress llvm/test/Other/can-execute.txt on msys bash.
>>
>> Modified:
>>     llvm/trunk/test/Other/can-execute.txt
>>     llvm/trunk/test/lit.cfg
>>
>> Modified: llvm/trunk/test/Other/can-execute.txt
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Other/can-execute.txt?rev=184932&r1=184931&r2=184932&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Other/can-execute.txt (original)
>> +++ llvm/trunk/test/Other/can-execute.txt Wed Jun 26 05:56:44 2013
>> @@ -1,4 +1,4 @@
>> -REQUIRES: shell
>> +REQUIRES: can-execute
>>
>>  This tests that we abstract two peculiarities of unix in can_execute:
>>
>>
>> Modified: llvm/trunk/test/lit.cfg
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/lit.cfg?rev=184932&r1=184931&r2=184932&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/lit.cfg (original)
>> +++ llvm/trunk/test/lit.cfg Wed Jun 26 05:56:44 2013
>> @@ -250,6 +250,10 @@ for pattern in [r"\bbugpoint\b(?!-)",
>>  if execute_external:
>>      config.available_features.add('shell')
>>
>> +# Others/can-execute.txt
>> +if sys.platform not in ['win32']:
>> +    config.available_features.add('can-execute')
>> +
>>  # Loadable module
>>  # FIXME: This should be supplied by Makefile or autoconf.
>>  if sys.platform in ['win32', 'cygwin']:
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits