[llvm] r184971 - Use enums instead of raw octal values.
Rafael Espindola
rafael.espindola at gmail.com
Wed Jun 26 10:28:04 PDT 2013
Author: rafael
Date: Wed Jun 26 12:28:04 2013
New Revision: 184971
URL: http://llvm.org/viewvc/llvm-project?rev=184971&view=rev
Log:
Use enums instead of raw octal values.
Patch by 罗勇刚(Yonggang Luo).
Modified:
llvm/trunk/include/llvm/Support/FileSystem.h
llvm/trunk/lib/Support/Unix/PathV2.inc
llvm/trunk/tools/llvm-ar/ArchiveWriter.cpp
Modified: llvm/trunk/include/llvm/Support/FileSystem.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/FileSystem.h?rev=184971&r1=184970&r2=184971&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/FileSystem.h (original)
+++ llvm/trunk/include/llvm/Support/FileSystem.h Wed Jun 26 12:28:04 2013
@@ -111,6 +111,9 @@ enum perms {
others_write = 02,
others_exe = 01,
others_all = others_read | others_write | others_exe,
+ all_read = owner_read | group_read | others_read,
+ all_write = owner_write | group_write | others_write,
+ all_exe = owner_exe | group_exe | others_exe,
all_all = owner_all | group_all | others_all,
set_uid_on_exe = 04000,
set_gid_on_exe = 02000,
@@ -559,15 +562,17 @@ error_code status_known(const Twine &pat
/// @param result_path Set to the opened file's absolute path.
/// @param makeAbsolute If true and \a model is not an absolute path, a temp
/// directory will be prepended.
+/// @param mode Set to the file open mode; since this is most often used for
+/// temporary files, mode defaults to owner_read | owner_write.
/// @returns errc::success if result_{fd,path} have been successfully set,
/// otherwise a platform specific error_code.
error_code unique_file(const Twine &model, int &result_fd,
SmallVectorImpl<char> &result_path,
- bool makeAbsolute = true, unsigned mode = 0600);
+ bool makeAbsolute = true, unsigned mode = owner_read | owner_write);
/// @brief Simpler version for clients that don't want an open file.
error_code unique_file(const Twine &Model, SmallVectorImpl<char> &ResultPath,
- bool MakeAbsolute = true, unsigned Mode = 0600);
+ bool MakeAbsolute = true, unsigned Mode = owner_read | owner_write);
/// @brief Canonicalize path.
///
Modified: llvm/trunk/lib/Support/Unix/PathV2.inc
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Unix/PathV2.inc?rev=184971&r1=184970&r2=184971&view=diff
==============================================================================
--- llvm/trunk/lib/Support/Unix/PathV2.inc (original)
+++ llvm/trunk/lib/Support/Unix/PathV2.inc Wed Jun 26 12:28:04 2013
@@ -564,7 +564,6 @@ error_code setLastModificationAndAccessT
return error_code::success();
}
-// Since this is most often used for temporary files, mode defaults to 0600.
error_code unique_file(const Twine &model, int &result_fd,
SmallVectorImpl<char> &result_path,
bool makeAbsolute, unsigned mode) {
Modified: llvm/trunk/tools/llvm-ar/ArchiveWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-ar/ArchiveWriter.cpp?rev=184971&r1=184970&r2=184971&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-ar/ArchiveWriter.cpp (original)
+++ llvm/trunk/tools/llvm-ar/ArchiveWriter.cpp Wed Jun 26 12:28:04 2013
@@ -268,7 +268,7 @@ bool Archive::writeToDisk(bool TruncateN
int TmpArchiveFD;
SmallString<128> TmpArchive;
error_code EC = sys::fs::unique_file("temp-archive-%%%%%%%.a", TmpArchiveFD,
- TmpArchive, true, 0666);
+ TmpArchive, true, sys::fs::all_read | sys::fs::all_write);
if (EC)
return true;
More information about the llvm-commits
mailing list