[llvm] r184630 - Create the file with the right permissions instead of setting it afterwards.
罗勇刚(Yonggang Luo)
luoyonggang at gmail.com
Wed Jun 26 10:13:06 PDT 2013
Please commit for me, I doesn't have the write access.
2013/6/27 Rafael Espíndola <rafael.espindola at gmail.com>:
> LGTM (Looks Good To Me). Do you have write access?
>
> On 26 June 2013 13:08, 罗勇刚(Yonggang Luo) <luoyonggang at gmail.com> wrote:
>> Ping it and with updated patches.
>> It's compiled successful on win32.
>>
>> 2013/6/25 Rafael Espíndola <rafael.espindola at gmail.com>:
>>>> I just noticed all_read | all_write should be sys::fs::all_read |
>>>> sys::fs::all_write
>>>
>>> LGTM with that fixed.
>>>
>>> Cheers,
>>> Rafael
>>
>>
>>
>> --
>> 此致
>> 礼
>> 罗勇刚
>> Yours
>> sincerely,
>> Yonggang Luo
--
此致
礼
罗勇刚
Yours
sincerely,
Yonggang Luo
More information about the llvm-commits
mailing list