[PATCH] [tsan] Move some suppressions-related code to common. Factor out code to be reused in LSan. Also switch from linked list to vector.

Dmitry Vyukov dvyukov at google.com
Wed Jun 26 08:05:42 PDT 2013



================
Comment at: lib/sanitizer_common/sanitizer_suppressions.h:45
@@ +44,3 @@
+  uptr SuppressionCount();
+  void GetMatched(InternalMmapVector<Suppression *> *matched);
+
----------------
Sergey Matveev wrote:
> Dmitry Vyukov wrote:
> > Sergey Matveev wrote:
> > > Dmitry Vyukov wrote:
> > > > I would add PrintMatched() method, then this is unnecesasry
> > > > 
> > > PrintMatched() *is* tool-specific.
> > How will it be different for lsan?
> It will print the # of bytes leaked, at least.
just don't print it if it's zero


http://llvm-reviews.chandlerc.com/D1037



More information about the llvm-commits mailing list