[PATCH] [tsan] Move some suppressions-related code to common. Factor out code to be reused in LSan. Also switch from linked list to vector.

[Dmitry Vyukov]

================
Comment at: lib/sanitizer_common/sanitizer_suppressions.h:21
@@ +20,3 @@
+
+enum SuppressionType {
+  SuppressionNone,
----------------
why it is here now?
it's tool-specific.

================
Comment at: lib/sanitizer_common/sanitizer_suppressions.h:36
@@ +35,3 @@
+
+class SuppressionContextTest;
+
----------------
this is unnecessary, remove

================
Comment at: lib/sanitizer_common/sanitizer_suppressions.h:42
@@ +41,3 @@
+  void Parse(const char *str);
+  void FinishInitialization() { initialized_ = true; }
+  bool Match(const char* str, SuppressionType type, Suppression **s);
----------------
set initialized_=true in Match()?

================
Comment at: lib/sanitizer_common/sanitizer_suppressions.h:45
@@ +44,3 @@
+  uptr SuppressionCount();
+  void GetMatched(InternalMmapVector<Suppression *> *matched);
+
----------------
I would add PrintMatched() method, then this is unnecesasry



http://llvm-reviews.chandlerc.com/D1037