[PATCH] [PATCH] Add a subtarget feature "v8" to ARM

[Joey Gouly]

  > To me it looks like there are a couple of patches here:
  > + Support v8
  > + Stop emitting v7 attributes when the compiler has really selected something like v4

  Yes, that's right. Shall I split out the attributes part first? Or can I just commit them separately? I had to do that for the v8 attributes to work. It used to first check that the CPU was "generic", and if so, emit attributes for a v7a, whereas codegen emits for v4 by default.

  > The latter change appears to have no tests.
  That's the change to the 'mc-elf-objheader.ll' file.

  > Are you really sure you want to support v8m at this stage, let alone
  > in such a half-hearted way? I'd have wanted to get the v8a features
  > correct first, since if nothing else cortex-a53 is an A-class core.

  No, that should be removed, thanks.

  > It would also be good to see a test for "thumbv8" since that's likely
  > to be used quite a bit.
  Will do.

  Thanks,
  Joey

http://llvm-reviews.chandlerc.com/D1041

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D1041?vs=2564&id=2569#toc

Files:
  lib/Target/ARM/ARM.td
  lib/Target/ARM/ARMAsmPrinter.cpp
  lib/Target/ARM/ARMBuildAttrs.h
  lib/Target/ARM/ARMInstrInfo.td
  lib/Target/ARM/ARMSubtarget.cpp
  lib/Target/ARM/ARMSubtarget.h
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp
  test/CodeGen/ARM/2010-09-29-mc-asm-header-test.ll
  test/CodeGen/ARM/2010-10-19-mc-elf-objheader.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1041.2.patch
Type: text/x-patch
Size: 8770 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130626/b53144bc/attachment.bin>