[PATCH] Support Mach-O universal binaries in llvm-symbolizer

[Alexander Potapenko]

  Mostly LGTM


================
Comment at: docs/CommandGuide/llvm-symbolizer.rst:72
@@ +71,3 @@
+
+ If a binary contains object files for multiple architectures (e.g. it is a Mac
+ universal binary), symbolize the object file for a given architecture. You can
----------------
Mach-O universal binary

================
Comment at: test/DebugInfo/Inputs/macho-universal.cc:9
@@ +8,3 @@
+
+// Built with Apple LLVM version 4.2 (clang-425.0.24) (based on LLVM 3.2svn)
+// clang++ -arch x86_64 -arch i386 macho-universal.cc
----------------
Why not use the current Clang to build the binary? It'll be easier to reproduce if needed.
Also, I'd put the comment on the top of the file (unless you're following some LLVM convention)

================
Comment at: test/DebugInfo/llvm-symbolizer.test:11
@@ -9,1 +10,3 @@
+RUN: llvm-symbolizer --functions --inlining --demangle=false \
+RUN:    --default-arch=i386 < %t.input | FileCheck %s
 
----------------
How does it behave without --default-arch?


http://llvm-reviews.chandlerc.com/D1029