[PATCH] Bugpoint execution output file name (and sys::fs::unique_file)

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jun 25 22:40:31 PDT 2013


>
> --- a/tools/bugpoint/ExecutionDriver.cpp
> +++ b/tools/bugpoint/ExecutionDriver.cpp
> @@ -328,7 +328,7 @@ std::string BugDriver::executeProgram(const Module *Program,
>    FileRemover BitcodeFileRemover(BitcodePath,
>      CreatedBitcode && !SaveTemps);
>
> -  if (OutputFile.empty()) OutputFile = OutputPrefix + "-execution-output";
> +  if (OutputFile.empty()) OutputFile = OutputPrefix + "-execution-output-%%%%%%%";
>
>    // Check to see if this is a valid output filename...
>    SmallString<128> UniqueFile;

LGTM. Sorry, this is probably a regression from my patches moving away
from PathV1.

> but maybe sys::fs::unique_file should be changed instead?

I think a higher lever interface where we just pass a prefix and a
extension would make sense, but for now your patch is probably the
best solution.

> Thanks again,
> Hal

Cheers,
Rafael



More information about the llvm-commits mailing list