[PATCH] Vselect improvements part 2

Nadav Rotem nrotem at apple.com
Tue Jun 25 00:14:10 PDT 2013


  Matt,

  This change looks incorrect.  The function SplitVecOp_VSETCC should split setcc nodes. Your change makes it convert the i1s return type into OutVT which may not be a legal type. The last part is especially suspicious. Why are you handling VSETCCs that return vector i1s or something else ? The VSETCCs need to be consistent. I think that at this phase they are all i1s.

  Nadav

http://llvm-reviews.chandlerc.com/D904



More information about the llvm-commits mailing list