[PATCH] ARM: operands should be explicit when disassembled
Amaury de la Vieuville
amaury.dlv at gmail.com
Mon Jun 24 01:43:01 PDT 2013
Hi Tim,
>Isn't this function only used for post-indexed instructions? If not,
it's wrong; if so, could you change the function and operand names to
reflect that? To me "offset" mode implies the "[reg, #imm]" form.
It seems to me that the `_offset` prefix is used with post-indexed instructions, and `_pre` is used with pre-indexed instructions.
Thanks,
Amaury
http://llvm-reviews.chandlerc.com/D1019
More information about the llvm-commits
mailing list