[llvm] r184583 - [objcarcopts] Encapsulated PtrState.RRI.IsTrackingImpreciseRelease() => PtrState.IsTrackingImpreciseRelease().

[Bill Wendling]

On Jun 21, 2013, at 12:12 PM, Michael Gottesman <mgottesman at apple.com> wrote:

> Author: mgottesman
> Date: Fri Jun 21 14:12:38 2013
> New Revision: 184583
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=184583&view=rev
> Log:
> [objcarcopts] Encapsulated PtrState.RRI.IsTrackingImpreciseRelease() => PtrState.IsTrackingImpreciseRelease().
> 
> Modified:
>    llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp
> 
> Modified: llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp?rev=184583&r1=184582&r2=184583&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp (original)
> +++ llvm/trunk/lib/Transforms/ObjCARC/ObjCARCOpts.cpp Fri Jun 21 14:12:38 2013
> @@ -469,9 +469,6 @@ namespace {
>     /// occured, false otherwise.
>     bool Merge(const RRInfo &Other);
> 
> -    bool IsTrackingImpreciseReleases() {
> -      return ReleaseMetadata != 0;
> -    }
>   };
> }
> 
> @@ -547,6 +544,10 @@ namespace {
>       RRI.IsTailCallRelease = NewValue;
>     }
> 
> +    bool IsTrackingImpreciseReleases() {
> +      return RRI.ReleaseMetadata != 0;
> +    }

Can you make this method "const"?

-bw

> +
>     const MDNode *GetReleaseMetadata() const {
>       return RRI.ReleaseMetadata;
>     }
> @@ -1967,7 +1968,7 @@ ObjCARCOpt::VisitInstructionBottomUp(Ins
>     case S_Use:
>       // If OldSeq is not S_Use or OldSeq is S_Use and we are tracking an
>       // imprecise release, clear our reverse insertion points.
> -      if (OldSeq != S_Use || S.RRI.IsTrackingImpreciseReleases())
> +      if (OldSeq != S_Use || S.IsTrackingImpreciseReleases())
>         S.RRI.ReverseInsertPts.clear();
>       // FALL THROUGH
>     case S_CanRelease:
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits