[lld] r184585 - Removed unnecessary "class" keyword.
Shankar Easwaran
shankare at codeaurora.org
Fri Jun 21 12:35:39 PDT 2013
I used this grep pattern and found more of it :-
find . -name '*.h' -o -name '*.cpp' | xargs grep '(.*class.*)'
./lib/ReaderWriter/Native/WriterNative.cpp: uint32_t
getContentOffset(const class DefinedAtom& atom) {
./lib/ReaderWriter/Native/WriterNative.cpp: uint32_t
getAttributeOffset(const class DefinedAtom& atom) {
./lib/ReaderWriter/Native/WriterNative.cpp: uint32_t
getAttributeOffset(const class AbsoluteAtom& atom) {
./lib/ReaderWriter/Native/WriterNative.cpp: uint32_t
sectionNameOffset(const class DefinedAtom& atom) {
./lib/ReaderWriter/MachO/WriterMachO.cpp: DyldInfoChunk(class
MachOWriter &);
./lib/ReaderWriter/MachO/WriterMachO.cpp: BindingInfoChunk(class
MachOWriter &);
./lib/ReaderWriter/MachO/WriterMachO.cpp: LazyBindingInfoChunk(class
MachOWriter &);
./lib/ReaderWriter/MachO/WriterMachO.cpp: SymbolTableChunk(class
SymbolStringsChunk&, MachOWriter&);
./lib/Core/Resolver.cpp:void Resolver::doUndefinedAtom(const class
UndefinedAtom& atom) {
./include/lld/Core/InputFiles.h: virtual void doFile(const class File
&) = 0;
./include/lld/Core/InputFiles.h: virtual void doDefinedAtom(const
class DefinedAtom &) = 0;
./include/lld/Core/InputFiles.h: virtual void doUndefinedAtom(const
class UndefinedAtom &) = 0;
./include/lld/Core/InputFiles.h: virtual void
doSharedLibraryAtom(const class SharedLibraryAtom &) = 0;
./include/lld/Core/InputFiles.h: virtual void doAbsoluteAtom(const
class AbsoluteAtom &) = 0;
./include/lld/Core/Resolver.h: virtual void doDefinedAtom(const class
DefinedAtom&);
./include/lld/Core/Resolver.h: virtual void doUndefinedAtom(const class
UndefinedAtom&);
./include/lld/Core/Resolver.h: virtual void doSharedLibraryAtom(const
class SharedLibraryAtom &);
./include/lld/Core/Resolver.h: virtual void doAbsoluteAtom(const class
AbsoluteAtom &);
Thanks
Shankar Easwaran
On 6/21/2013 2:30 PM, Rui Ueyama wrote:
> Author: ruiu
> Date: Fri Jun 21 14:30:16 2013
> New Revision: 184585
>
> URL: http://llvm.org/viewvc/llvm-project?rev=184585&view=rev
> Log:
> Removed unnecessary "class" keyword.
>
> Modified:
> lld/trunk/include/lld/Core/Atom.h
> lld/trunk/include/lld/Core/Reference.h
> lld/trunk/include/lld/ReaderWriter/Simple.h
> lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h
>
> Modified: lld/trunk/include/lld/Core/Atom.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/Atom.h?rev=184585&r1=184584&r2=184585&view=diff
> ==============================================================================
> --- lld/trunk/include/lld/Core/Atom.h (original)
> +++ lld/trunk/include/lld/Core/Atom.h Fri Jun 21 14:30:16 2013
> @@ -53,7 +53,7 @@ public:
>
>
> /// file - returns the File that produced/owns this Atom
> - virtual const class File& file() const = 0;
> + virtual const File& file() const = 0;
>
> /// name - The name of the atom. For a function atom, it is the (mangled)
> /// name of the function.
>
> Modified: lld/trunk/include/lld/Core/Reference.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/Reference.h?rev=184585&r1=184584&r2=184585&view=diff
> ==============================================================================
> --- lld/trunk/include/lld/Core/Reference.h (original)
> +++ lld/trunk/include/lld/Core/Reference.h Fri Jun 21 14:30:16 2013
> @@ -14,6 +14,7 @@
> #include "llvm/ADT/StringSwitch.h"
>
> namespace lld {
> +class Atom;
>
> ///
> /// The linker has a Graph Theory model of linking. An object file is seen
> @@ -81,11 +82,11 @@ public:
>
> /// If the reference is an edge to another Atom, then this returns the
> /// other Atom. Otherwise, it returns nullptr.
> - virtual const class Atom * target() const = 0;
> + virtual const Atom *target() const = 0;
>
> /// During linking, the linker may merge graphs which coalesces some nodes
> /// (i.e. Atoms). To switch the target of a reference, this method is called.
> - virtual void setTarget(const class Atom *) = 0;
> + virtual void setTarget(const Atom *) = 0;
>
> /// Some relocations require a symbol and a value (e.g. foo + 4).
> virtual Addend addend() const = 0;
>
> Modified: lld/trunk/include/lld/ReaderWriter/Simple.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/ReaderWriter/Simple.h?rev=184585&r1=184584&r2=184585&view=diff
> ==============================================================================
> --- lld/trunk/include/lld/ReaderWriter/Simple.h (original)
> +++ lld/trunk/include/lld/ReaderWriter/Simple.h Fri Jun 21 14:30:16 2013
> @@ -176,7 +176,7 @@ public:
> }
>
> /// file - returns the File that produced/owns this Atom
> - virtual const class File &file() const { return _file; }
> + virtual const File &file() const { return _file; }
>
> /// name - The name of the atom. For a function atom, it is the (mangled)
> /// name of the function.
>
> Modified: lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h?rev=184585&r1=184584&r2=184585&view=diff
> ==============================================================================
> --- lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h (original)
> +++ lld/trunk/lib/ReaderWriter/PECOFF/Atoms.h Fri Jun 21 14:30:16 2013
> @@ -60,7 +60,7 @@ public:
> COFFAbsoluteAtom(const File &f, llvm::StringRef n, const coff_symbol *s)
> : _owningFile(f), _name(n), _symbol(s) {}
>
> - virtual const class File &file() const { return _owningFile; }
> + virtual const File &file() const { return _owningFile; }
>
> virtual Scope scope() const {
> if (_symbol->StorageClass == llvm::COFF::IMAGE_SYM_CLASS_STATIC)
> @@ -83,7 +83,7 @@ public:
> COFFUndefinedAtom(const File &f, llvm::StringRef n)
> : _owningFile(f), _name(n) {}
>
> - virtual const class File &file() const { return _owningFile; }
> + virtual const File &file() const { return _owningFile; }
>
> virtual llvm::StringRef name() const { return _name; }
>
> @@ -102,7 +102,7 @@ public:
> : _owningFile(f), _name(n), _symbol(symb), _section(sec), _data(d),
> _sectionName(sectionName), _ordinal(ordinal) {}
>
> - virtual const class File &file() const { return _owningFile; }
> + virtual const File &file() const { return _owningFile; }
>
> virtual llvm::StringRef name() const { return _name; }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation
More information about the llvm-commits
mailing list