[llvm] r184535 - Fix an ordering problem in the test.

[Manuel Klimek]

On Fri, Jun 21, 2013 at 4:16 PM, David Blaikie <dblaikie at gmail.com> wrote:

> Moo
>
> On Jun 21, 2013 12:26 AM, "Manuel Klimek" <klimek at google.com> wrote:
> >
> > Author: klimek
> > Date: Fri Jun 21 02:23:14 2013
> > New Revision: 184535
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=184535&view=rev
> > Log:
> > Fix an ordering problem in the test.
> >
> > The output can be in different orders, which breaks the test in some
> > situations. I have not yet found out what the root cause of the order
> > difference is. This fixes our internal build. If it is not the right
> > solution, feel free to roll back.
>
> I have the distinct impression we've seen similar directory listing
> ordering bugs before and fixed them in code by sorting the listing or some
> other approach (rather than by changing tests)
>

If somebody tells me which code to fix I'd be happy to do so :)


> >
> > Modified:
> >     llvm/trunk/test/Archive/directory.ll
> >
> > Modified: llvm/trunk/test/Archive/directory.ll
> > URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Archive/directory.ll?rev=184535&r1=184534&r2=184535&view=diff
> >
> ==============================================================================
> > --- llvm/trunk/test/Archive/directory.ll (original)
> > +++ llvm/trunk/test/Archive/directory.ll Fri Jun 21 02:23:14 2013
> > @@ -5,7 +5,7 @@
> >  ;RUN: touch %T/a-very-long-file-name
> >  ;RUN: llvm-ar r %T/test.a %s %T/a-very-long-file-name
> >  ;RUN: llvm-ar r %T/test.a %T/a-very-long-file-name
> > -;RUN: llvm-ar t %T/test.a | FileCheck -check-prefix=MEMBERS %s
> > +;RUN: llvm-ar t %T/test.a | sort | FileCheck -check-prefix=MEMBERS %s
> >  ;MEMBERS-NOT: /
> >  ;MEMBERS: a-very-long-file-name
> >  ;MEMBERS: directory.ll
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130621/3380a9d7/attachment.html>