[PATCH] [TargetInfo] Move LinkerInputFile to TargetInfo and rename more specific name

Rui Ueyama ruiu at google.com
Thu Jun 20 21:58:33 PDT 2013


  I think I understand your point, but doesn't it lead to code duplication? All ELF/Mach-O/COFF needs the same feature in the same way, and this code seems to cover all three cases fairly nicely.

  Linker internal file doesn't need to be the only one. Handling "-u" option in my way won't prevent you from doing ELF specific thing, I think. If you need a target specific internal file, you can define a new one in a target specific directory, and add its instance to the LinkerInput. Doesn't this separation make sense?

http://llvm-reviews.chandlerc.com/D1016



More information about the llvm-commits mailing list