submit [PATCH] SimplifyCFG for code review

Sean Silva silvas at purdue.edu
Thu Jun 20 16:55:52 PDT 2013


On Thu, Jun 20, 2013 at 4:26 PM, Ye, Mei <Mei.Ye at amd.com> wrote:

>  Hi Sean****
>
> ** **
>
> See the attached new patch, which fixes all issues brought up by you.****
>
> I ran “clang-format” on whole files which makes more diffs.  Hopefully
> this is OK with you.
>

Thanks for using clang-format, but unfortunately it's not OK to have
unrelated formatting changes in a patch. Please run clang-format over just
the added or modified code. (you may want to try clang-format-diff.py; see <
http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting>)


> ****
>
> It will be nice if the check-in process can automatically run
> “clang-format”. ****
>
> **
>

Yeah. Someday we will hopefully have that set up!

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130620/e308e036/attachment.html>


More information about the llvm-commits mailing list