submit [PATCH] SimplifyCFG for code review

[Ye, Mei]

Hi Sean

See the attached new patch, which fixes all issues brought up by you.
I ran "clang-format" on whole files which makes more diffs.  Hopefully this is OK with you.
It will be nice if the check-in process can automatically run "clang-format".

-Mei

From: Sean Silva [mailto:silvas at purdue.edu]
Sent: Tuesday, June 18, 2013 4:48 PM
To: Ye, Mei
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: submit [PATCH] SimplifyCFG for code review



On Tue, Jun 18, 2013 at 4:27 PM, Ye, Mei <Mei.Ye at amd.com<mailto:Mei.Ye at amd.com>> wrote:
Hi Sean

There are some considerations that go into this test sample to create an opportunity for the transformation.
The test case should run *only* the simplifycfg pass (I see now that you have `-O3` in your test case; please remove `-O3`). You can probably just write a simple .ll function with IR that looks like the "Before" case in your documentation comment.

Also,

+; RUN: opt < %s -O3 -simplifycfg -S | grep br | count 2
+%struct.float2_tag = type { float, float }

Please use FileCheck for all new tests. Using grep is deprecated.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130620/01ace7ce/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: odc_simplifycfg
Type: application/octet-stream
Size: 151567 bytes
Desc: odc_simplifycfg
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130620/01ace7ce/attachment.obj>