[llvm] r184484 - Remove last use of PathV1.h from Archive.cpp.

Rafael Espindola rafael.espindola at gmail.com
Thu Jun 20 15:02:10 PDT 2013


Author: rafael
Date: Thu Jun 20 17:02:10 2013
New Revision: 184484

URL: http://llvm.org/viewvc/llvm-project?rev=184484&view=rev
Log:
Remove last use of PathV1.h from Archive.cpp.

Modified:
    llvm/trunk/include/llvm/Support/FileSystem.h
    llvm/trunk/lib/Support/Unix/PathV2.inc
    llvm/trunk/tools/llvm-ar/Archive.cpp

Modified: llvm/trunk/include/llvm/Support/FileSystem.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/FileSystem.h?rev=184484&r1=184483&r2=184484&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/FileSystem.h (original)
+++ llvm/trunk/include/llvm/Support/FileSystem.h Thu Jun 20 17:02:10 2013
@@ -153,6 +153,8 @@ class file_status
   dev_t fs_st_dev;
   ino_t fs_st_ino;
   time_t fs_st_mtime;
+  uid_t fs_st_uid;
+  gid_t fs_st_gid;
   #elif defined (LLVM_ON_WIN32)
   uint32_t LastWriteTimeHigh;
   uint32_t LastWriteTimeLow;
@@ -177,6 +179,18 @@ public:
   perms permissions() const { return Perms; }
   TimeValue getLastModificationTime() const;
 
+  #if defined(LLVM_ON_UNIX)
+  uint32_t getUser() const { return fs_st_uid; }
+  uint32_t getGroup() const { return fs_st_gid; }
+  #elif defined (LLVM_ON_WIN32)
+  uint32_t getUser() const {
+    return 9999; // Not applicable to Windows, so...
+  }
+  uint32_t getGroup() const {
+    return 9999; // Not applicable to Windows, so...
+  }
+  #endif
+
   // setters
   void type(file_type v) { Type = v; }
   void permissions(perms p) { Perms = p; }

Modified: llvm/trunk/lib/Support/Unix/PathV2.inc
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Unix/PathV2.inc?rev=184484&r1=184483&r2=184484&view=diff
==============================================================================
--- llvm/trunk/lib/Support/Unix/PathV2.inc (original)
+++ llvm/trunk/lib/Support/Unix/PathV2.inc Thu Jun 20 17:02:10 2013
@@ -408,6 +408,8 @@ error_code status(const Twine &path, fil
   result.fs_st_dev = status.st_dev;
   result.fs_st_ino = status.st_ino;
   result.fs_st_mtime = status.st_mtime;
+  result.fs_st_uid = status.st_uid;
+  result.fs_st_gid = status.st_gid;
 
   return error_code::success();
 }

Modified: llvm/trunk/tools/llvm-ar/Archive.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-ar/Archive.cpp?rev=184484&r1=184483&r2=184484&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-ar/Archive.cpp (original)
+++ llvm/trunk/tools/llvm-ar/Archive.cpp Thu Jun 20 17:02:10 2013
@@ -18,7 +18,6 @@
 #include "llvm/IR/Module.h"
 #include "llvm/Support/FileSystem.h"
 #include "llvm/Support/MemoryBuffer.h"
-#include "llvm/Support/PathV1.h"
 #include "llvm/Support/Process.h"
 #include "llvm/Support/system_error.h"
 #include <cstring>
@@ -109,15 +108,21 @@ bool ArchiveMember::replaceWith(StringRe
   if (!signature) {
     sys::fs::get_magic(path, magic.capacity(), magic);
     signature = magic.c_str();
-    sys::PathWithStatus PWS(path);
-    const sys::FileStatus *FSinfo = PWS.getFileStatus(false, ErrMsg);
-    if (!FSinfo)
+
+    sys::fs::file_status Status;
+    error_code EC = sys::fs::status(path, Status);
+    if (EC)
+      return true;
+
+    User = Status.getUser();
+    Group = Status.getGroup();
+    Mode = Status.permissions();
+    ModTime = Status.getLastModificationTime();
+
+    // FIXME: On posix this is a second stat.
+    EC = sys::fs::file_size(path, Size);
+    if (EC)
       return true;
-    User = FSinfo->getUser();
-    Group = FSinfo->getGroup();
-    Mode = FSinfo->getMode();
-    ModTime = FSinfo->getTimestamp();
-    Size = FSinfo->getSize();
   }
 
   // Determine what kind of file it is.





More information about the llvm-commits mailing list