[PATCH] ARM: enable decoding of pc-relative PLD/PLI

Amaury de la Vieuville amaury.dlv at gmail.com
Thu Jun 20 06:44:05 PDT 2013



================
Comment at: lib/Target/ARM/ARMInstrThumb2.td:1642
@@ +1641,3 @@
+
+    let DecoderMethod = "DecodeT2LoadLabel";
+  }
----------------
Renato Golin wrote:
> Shouldn't this be DecodeT2LoadImm12?
No, this is a pc-relative operand. Imm12 is `reg+off`, this is just `off` here.

================
Comment at: lib/Target/ARM/ARMInstrThumb2.td:1039
@@ -1038,1 +1038,3 @@
+    bits<13> addr;
+    let Inst{23} = addr{12}; // add = (U == '1')
     let Inst{11-0}  = addr{11-0};
----------------
Renato Golin wrote:
> This seems like a pointless movement of code...
Just trying to keep the pci variants consistent with the new changes, should I revert?


http://llvm-reviews.chandlerc.com/D1001



More information about the llvm-commits mailing list