[llvm] r184239 - We want a string representation of the attribute, not the kind as a string.

David Blaikie dblaikie at gmail.com
Tue Jun 18 14:35:30 PDT 2013


On Tue, Jun 18, 2013 at 2:27 PM, Bill Wendling <isanbard at gmail.com> wrote:
> Author: void
> Date: Tue Jun 18 16:27:00 2013
> New Revision: 184239
>
> URL: http://llvm.org/viewvc/llvm-project?rev=184239&view=rev
> Log:
> We want a string representation of the attribute, not the kind as a string.

Test case? (do we have test cases for the verifier?)

>
> Modified:
>     llvm/trunk/lib/IR/Verifier.cpp
>
> Modified: llvm/trunk/lib/IR/Verifier.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Verifier.cpp?rev=184239&r1=184238&r2=184239&view=diff
> ==============================================================================
> --- llvm/trunk/lib/IR/Verifier.cpp (original)
> +++ llvm/trunk/lib/IR/Verifier.cpp Tue Jun 18 16:27:00 2013
> @@ -695,11 +695,11 @@ void Verifier::VerifyAttributeTypes(Attr
>          I->getKindAsEnum() == Attribute::NoBuiltin ||
>          I->getKindAsEnum() == Attribute::Cold) {
>        if (!isFunction)
> -          CheckFailed("Attribute '" + I->getKindAsString() +
> +          CheckFailed("Attribute '" + I->getAsString() +
>                        "' only applies to functions!", V);
>            return;
>      } else if (isFunction) {
> -        CheckFailed("Attribute '" + I->getKindAsString() +
> +        CheckFailed("Attribute '" + I->getAsString() +
>                      "' does not apply to functions!", V);
>          return;
>      }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list