[patch] fix loopvectorizer bug with multiple address spaces PR16306

Tom Stellard tom at stellard.net
Mon Jun 17 12:43:32 PDT 2013


Hi Nadav,

Is it OK to merge this patch into the 3.3 branch for the 3.3.1 release?

-Tom

On Mon, Jun 17, 2013 at 11:01:31AM -0700, Nadav Rotem wrote:
> Pekka, 
> 
> LGTM.  Please also make sure that we are not dropping the address space for Loads. 
> 
> Thanks,
> Nadav
> 
> On Jun 17, 2013, at 10:57 AM, Eli Friedman <eli.friedman at gmail.com> wrote:
> 
> > Forwarding to the correct list.
> > 
> > ---------- Forwarded message ----------
> > From: Pekka Jääskeläinen <pekka.jaaskelainen at tut.fi>
> > Date: Mon, Jun 17, 2013 at 8:06 AM
> > Subject: [patch] fix loopvectorizer bug with multiple address spaces PR16306
> > To: cfe-commits at cs.uiuc.edu
> > 
> > 
> > Hello,
> > 
> > Attached patch fixes a severe regression caused by LoopVectorizer when
> > vectorizing loops with memory accesses to non-zero address spaces. It
> > simply drops the AS info. It's a rather nasty problem as there is no
> > way (at least known to me) to disable the loop vectorizer *only* from
> > clang/opt command line.
> > 
> > Seems like an obvious fix.
> > 
> > http://llvm.org/bugs/show_bug.cgi?id=16306
> > 
> > The patch applies to trunk and 3.3 branches. Tom, could you apply
> > this to the (upcoming?) 3.3 maintenance branch as well?
> > 
> > Thanks,
> > -- 
> > --Pekka
> > 
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> > 
> > 
> > <loopvec-address-space-fix.patch>
> 

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list