[patch] Use "set -o pipefail"

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Jun 17 07:16:56 PDT 2013


ping.

On 12 June 2013 14:03, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> It is fairly inconvenient for tests like
>
> opt ... | FileCheck
>
> to pass if opt returns false after printing what FileCheck was looking
> for. The attached patch adds "set -o pipefail" to the testscript that
> lit creates.
>
> The patch adds a test that only passes if pipefail is enabled and
> deletes to old tests:
>
> * test/CodeGen/X86/2007-05-07-InvokeSRet.ll: It had invalid IL.
> * test/CodeGen/X86/2008-02-08-LoadFoldingBug.ll: it was running "grep
> andpd | not grep esp" and passing because we were not printing any
> andpd.
>
> I have tested that it works on linux and OS X. Is it OK if I also
> update clang and lld tests?
>
> Cheers,
> Rafael




More information about the llvm-commits mailing list