[PATCH] DataFlowSanitizer; compiler-rt changes.
Alexey Samsonov
samsonov at google.com
Mon Jun 17 07:03:19 PDT 2013
================
Comment at: include/sanitizer/dfsan_interface.h:17
@@ +16,3 @@
+
+#include <stddef.h>
+#include <stdint.h>
----------------
Kostya Serebryany wrote:
> [we discussed this a few times before]
> We do not allow system includes in asan/tsan/msan/sanitizer_common files (other than OS-specific ones).
> This rule does not have to be followed in dfsan, but you have been warned -- using stddef/stdint in sanitizers may cause you PAIN while porting to non-linux.
> And you may easily avoid these headers.
This is OK, as this is a public header.
That's why we actually don't include public interface headers in sanitizer code - we create a "copy" of them, and declare the functions using our own type system (uptr instead of size_t etc.)
http://llvm-reviews.chandlerc.com/D967
BRANCH
dfsan-up
ARCANIST PROJECT
compiler-rt
More information about the llvm-commits
mailing list