[PATCH] Initial support for Mach-O universal binaries in LLVMObject

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Jun 14 18:00:49 PDT 2013



================
Comment at: include/llvm/Object/MachOUniversal.h:44
@@ +43,3 @@
+  // Stores descriptors for contained objects.
+  SmallVector<macho::FatArchHeader, 4> Objects;
+};
----------------
Is it profitable to cache this? I expect the common cases to be

* User wants one architecture. We may as well scan when they call getObjectForArch instead of scanning in the constructor.
* User wants all the architectures. We should provide an iterator.


http://llvm-reviews.chandlerc.com/D978



More information about the llvm-commits mailing list