[llvm] r183995 - Cmake: add compiler option in a more idiomatic way

[Arnaud A. de Grandmaison]

On Friday 14 June 2013 15:42:48 Rafael Espíndola wrote:
> Sorry, this broke the bots so I reverted it

Sorry for the inconvenience.

Interesting. This means that somehow add_flag_if_supported / 
check_cxx_compiler_flag is not behaving the way it should :(

> 
> On 14 June 2013 15:26, Arnaud A. de Grandmaison <arnaud.adegm at gmail.com> 
wrote:
> > Author: aadg
> > Date: Fri Jun 14 14:26:57 2013
> > New Revision: 183995
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=183995&view=rev
> > Log:
> > Cmake: add compiler option in a more idiomatic way
> > 
> > Modified:
> >     llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
> > 
> > Modified: llvm/trunk/cmake/modules/HandleLLVMOptions.cmake
> > URL:
> > http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/HandleLLVMOp
> > tions.cmake?rev=183995&r1=183994&r2=183995&view=diff
> > =========================================================================
> > ===== --- llvm/trunk/cmake/modules/HandleLLVMOptions.cmake (original)
> > +++ llvm/trunk/cmake/modules/HandleLLVMOptions.cmake Fri Jun 14 14:26:57
> > 2013 @@ -268,8 +268,6 @@ add_llvm_definitions( -D__STDC_FORMAT_MA
> > 
> >  add_llvm_definitions( -D__STDC_LIMIT_MACROS )
> >  
> >  # clang doesn't print colored diagnostics when invoked from Ninja
> > 
> > -if (UNIX AND
> > -    CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND
> > -    CMAKE_GENERATOR STREQUAL "Ninja")
> > -  append("-fcolor-diagnostics" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
> > +if (UNIX AND CMAKE_GENERATOR STREQUAL "Ninja")
> > +  add_flag_if_supported("-fcolor-diagnostics")
> > 
> >  endif()
> > 
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-- 
Arnaud A. de Grandmaison