[PATCH] DataFlowSanitizer; compiler-rt changes.
Peter Collingbourne
peter at pcc.me.uk
Fri Jun 14 12:26:43 PDT 2013
================
Comment at: include/sanitizer/dfsan_interface.h:1
@@ +1,2 @@
+//===-- dfsan_interface.h -------------------------------------------------===//
+//
----------------
Alexey Samsonov wrote:
> Please add this file to include/CMakeLists.txt
This file is already listed in include/CMakeLists.txt.
================
Comment at: include/sanitizer/dfsan_interface.h:71
@@ +70,3 @@
+#ifdef __cplusplus
+}
+
----------------
Alexander Potapenko wrote:
> nit: '} // extern "C"'
done
================
Comment at: lib/dfsan/lit_tests/basic.c:1
@@ +1,2 @@
+// RUN: %clang_dfsan -m64 %s -o %t && %t
+
----------------
Alexander Potapenko wrote:
> Please add comments that describe what your tests are testing.
done
================
Comment at: lib/dfsan/lit_tests/fncall.c:10
@@ +9,3 @@
+ dfsan_set_label(j_label, &j, sizeof(j));
+
+ return x + j;
----------------
Alexander Potapenko wrote:
> nit: spare newline
done
================
Comment at: lib/dfsan/lit_tests/lit.cfg:51
@@ +50,3 @@
+
+# Setup attributes common for all compiler-rt projects.
+compiler_rt_lit_cfg = os.path.join(llvm_src_root, "projects", "compiler-rt",
----------------
Alexey Samsonov wrote:
> You don't need this part now.
Merged in changes from r182726 and r183407.
================
Comment at: lib/dfsan/lit_tests/lit.cfg:72
@@ +71,3 @@
+
+# MemorySanitizer tests are currently supported on Linux only.
+if config.host_os not in ['Linux']:
----------------
Alexey Samsonov wrote:
> DataFlowSanitizer
done
http://llvm-reviews.chandlerc.com/D967
More information about the llvm-commits
mailing list