[llvm] r183809 - Correct the def registers for the 8bit x86 divide instructions to

Eric Christopher echristo at gmail.com
Fri Jun 14 11:17:42 PDT 2013


On Fri, Jun 14, 2013 at 11:12 AM, Evan Cheng <evan.cheng at apple.com> wrote:
> Hmmm. I am not sure how your patch fixes the bug. What's the difference between defs of AX and defs of AL, AH?
>
> I'm not saying this patch is wrong. But I suspicious it's fixing the bug by luck.
>

Oh it's definitely not fixing the bug at all, it's just having the
defs actually state specifically what's being set. The actual bug fix
for the PR is the other discussion that Jakob and I were having about
AltOrders and the fast register allocator. :)

-eric

> Evan
>
> On Jun 11, 2013, at 5:12 PM, Eric Christopher <echristo at gmail.com> wrote:
>
>> That's why I said by inspection... I could possibly come up with one
>> at some point. Maybe? I'm not sure how to trigger it other than via a
>> grep on the machine info output from PR16105.
>>
>> -eric
>>
>> On Tue, Jun 11, 2013 at 4:47 PM, Sean Silva <silvas at purdue.edu> wrote:
>>> Test case?
>>>
>>> -- Sean Silva
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list