R600 Patches: .td file cleanups and compute fixes for Cayman

Tom Stellard tom at stellard.net
Fri Jun 14 11:07:58 PDT 2013


On Fri, Jun 14, 2013 at 08:52:09AM -0700, Vincent Lejeune wrote:
> The serie is reviewed-by:Vincent Lejeune<vljn at ovi.com>
> 
> I think that we can drop the "useCustomInserter" modifier though,
> we always set the eop bit in the last NOP instruction in R600ControlFlowFinalizer Pass ;
> we could modify R600CFF later to allow it to mark the last export/memwrite as eop.
>

This makes sense I will do this in a follow on patch.

> In my opinion the eop should be set as late as possible : although the order of the
> export/rat_cacheless_write instruction is not modified until R600CFF pass at the moment, 
> some future optimizations (like a pass that will merge export instructions using burst count)
> may be easier to write if it does not have to deal with non default eop bit.
> 
>

I agree, this would be a nice optimization to have.

-Tom
 
> 
> 
> ----- Mail original -----
> > De : Tom Stellard <tom at stellard.net>
> > À : llvm-commits at cs.uiuc.edu
> > Cc : 
> > Envoyé le : Lundi 10 juin 2013 22h28
> > Objet : R600 Patches: .td file cleanups and compute fixes for Cayman
> > 
> > Hi,
> > 
> > The attached patches do some re-organization of the R600 .td files and
> > also fix some issues with compute shaders on Cayman.
> > 
> > -Tom
> > 
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >




More information about the llvm-commits mailing list