[PATCH] DataFlowSanitizer; compiler-rt changes.
Alexander Potapenko
glider at google.com
Fri Jun 14 04:25:34 PDT 2013
Several drive-by comments
================
Comment at: include/sanitizer/dfsan_interface.h:71
@@ +70,3 @@
+#ifdef __cplusplus
+}
+
----------------
nit: '} // extern "C"'
================
Comment at: include/sanitizer/dfsan_interface.h:80
@@ +79,2 @@
+
+#endif
----------------
nit: '#endif // DFSAN_INTERFACE_H'
================
Comment at: lib/dfsan/lit_tests/basic.c:1
@@ +1,2 @@
+// RUN: %clang_dfsan -m64 %s -o %t && %t
+
----------------
Please add comments that describe what your tests are testing.
================
Comment at: lib/dfsan/lit_tests/fncall.c:10
@@ +9,3 @@
+ dfsan_set_label(j_label, &j, sizeof(j));
+
+ return x + j;
----------------
nit: spare newline
http://llvm-reviews.chandlerc.com/D967
More information about the llvm-commits
mailing list