[llvm] r183863 - Revert r183854 (PPC: Fix switch warnings from r183841)

David Blaikie dblaikie at gmail.com
Wed Jun 12 13:57:33 PDT 2013


Author: dblaikie
Date: Wed Jun 12 15:57:32 2013
New Revision: 183863

URL: http://llvm.org/viewvc/llvm-project?rev=183863&view=rev
Log:
Revert r183854 (PPC: Fix switch warnings from r183841)

Now that the PRED_BAD has been removed, this is failing the Clang
-Werror build due to -Wcovered-switch-default.

Modified:
    llvm/trunk/lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp
    llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.cpp

Modified: llvm/trunk/lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp?rev=183863&r1=183862&r2=183863&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/InstPrinter/PPCInstPrinter.cpp Wed Jun 12 15:57:32 2013
@@ -90,7 +90,6 @@ void PPCInstPrinter::printPredicateOpera
 
   if (StringRef(Modifier) == "cc") {
     switch ((PPC::Predicate)Code) {
-    default: llvm_unreachable("Bad predicate!");
     case PPC::PRED_LT: O << "lt"; return;
     case PPC::PRED_LE: O << "le"; return;
     case PPC::PRED_EQ: O << "eq"; return;

Modified: llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.cpp?rev=183863&r1=183862&r2=183863&view=diff
==============================================================================
--- llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.cpp (original)
+++ llvm/trunk/lib/Target/PowerPC/MCTargetDesc/PPCPredicates.cpp Wed Jun 12 15:57:32 2013
@@ -18,7 +18,6 @@ using namespace llvm;
 
 PPC::Predicate PPC::InvertPredicate(PPC::Predicate Opcode) {
   switch (Opcode) {
-  default: llvm_unreachable("Unknown PPC branch opcode!");
   case PPC::PRED_EQ: return PPC::PRED_NE;
   case PPC::PRED_NE: return PPC::PRED_EQ;
   case PPC::PRED_LT: return PPC::PRED_GE;
@@ -28,11 +27,11 @@ PPC::Predicate PPC::InvertPredicate(PPC:
   case PPC::PRED_NU: return PPC::PRED_UN;
   case PPC::PRED_UN: return PPC::PRED_NU;
   }
+  llvm_unreachable("Unknown PPC branch opcode!");
 }
 
 PPC::Predicate PPC::getSwappedPredicate(PPC::Predicate Opcode) {
   switch (Opcode) {
-  default: llvm_unreachable("Unknown PPC branch opcode!");
   case PPC::PRED_EQ: return PPC::PRED_EQ;
   case PPC::PRED_NE: return PPC::PRED_NE;
   case PPC::PRED_LT: return PPC::PRED_GT;
@@ -42,5 +41,6 @@ PPC::Predicate PPC::getSwappedPredicate(
   case PPC::PRED_NU: return PPC::PRED_NU;
   case PPC::PRED_UN: return PPC::PRED_UN;
   }
+  llvm_unreachable("Unknown PPC branch opcode!");
 }
 





More information about the llvm-commits mailing list