[PATCH] ARM: Form paired load after stack coloring.

[Renato Golin]

On 11 June 2013 21:19, Quentin Colombet <qcolombet at apple.com> wrote:

> I do not know either and that is my point :). I wanted to get more
> information on why value is tested and never used.
> To me it is not relevant to use the value here.
>

I agree.


Agree, have you someone in mind that I could ping about that?
>

So, when in doubt, ask the code owner for the ARM back-end, which is Evan
Cheng. Luckily, in this case, the original code is his anyway (r73413, 15
Jun 2009). ;)

Evan,

Can you shed some light on what the getValue() is testing in this case?

+  // Must sure the base address satisfies i64 ld / st alignment
requirement.
+  if (!Op0->hasOneMemOperand() ||
+      !Op0->memoperands_begin()->getValue() ||
+      Op0->memoperands_begin()->isVolatile())

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130611/89633d44/attachment.html>