[llvm] r183736 - Rework r183728, suppress assert(0) for now. Its behavior depends on assertions on win32 hosts.

NAKAMURA Takumi geek4civic at gmail.com
Tue Jun 11 03:01:42 PDT 2013


Author: chapuni
Date: Tue Jun 11 05:01:42 2013
New Revision: 183736

URL: http://llvm.org/viewvc/llvm-project?rev=183736&view=rev
Log:
Rework r183728, suppress assert(0) for now. Its behavior depends on assertions on win32 hosts.

FIXME: Introduce yet another checker but assert(0).

Modified:
    llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
    llvm/trunk/test/MC/ARM/arm-thumb-cpus-default.s
    llvm/trunk/test/MC/ARM/arm-thumb-cpus.s

Modified: llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp?rev=183736&r1=183735&r2=183736&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp (original)
+++ llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp Tue Jun 11 05:01:42 2013
@@ -680,8 +680,11 @@ MCAsmBackend *llvm::createARMAsmBackend(
     return new DarwinARMAsmBackend(T, TT, CS);
   }
 
+#if 0
+  // FIXME: Introduce yet another checker but assert(0).
   if (TheTriple.isOSBinFormatCOFF())
-    llvm_unreachable("Windows not supported on ARM");
+    assert(0 && "Windows not supported on ARM");
+#endif
 
   uint8_t OSABI = MCELFObjectTargetWriter::getOSABI(Triple(TT).getOS());
   return new ELFARMAsmBackend(T, TT, OSABI);

Modified: llvm/trunk/test/MC/ARM/arm-thumb-cpus-default.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/arm-thumb-cpus-default.s?rev=183736&r1=183735&r2=183736&view=diff
==============================================================================
--- llvm/trunk/test/MC/ARM/arm-thumb-cpus-default.s (original)
+++ llvm/trunk/test/MC/ARM/arm-thumb-cpus-default.s Tue Jun 11 05:01:42 2013
@@ -5,9 +5,6 @@
 @ RUN: llvm-mc -show-encoding -triple=armv7m < %s | FileCheck %s --check-prefix=CHECK-THUMB-ONLY
 @ RUN: llvm-mc -show-encoding -triple=armv6m < %s | FileCheck %s --check-prefix=CHECK-THUMB-ONLY
 
-@ FIXME: Could we avoid XFAIL to specify triple above?
-@ XFAIL: cygwin,mingw32,win32
-
         @ Make sure the architecture chosen by LLVM defaults to a compatible
         @ ARM/Thumb mode.
         movs r0, r0

Modified: llvm/trunk/test/MC/ARM/arm-thumb-cpus.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/arm-thumb-cpus.s?rev=183736&r1=183735&r2=183736&view=diff
==============================================================================
--- llvm/trunk/test/MC/ARM/arm-thumb-cpus.s (original)
+++ llvm/trunk/test/MC/ARM/arm-thumb-cpus.s Tue Jun 11 05:01:42 2013
@@ -5,9 +5,6 @@
 @ RUN: llvm-mc -show-encoding -triple=armv7m < %s 2>&1 | FileCheck %s --check-prefix=CHECK-THUMB-ONLY
 @ RUN: llvm-mc -show-encoding -triple=armv6m < %s 2>&1 | FileCheck %s --check-prefix=CHECK-THUMB-ONLY
 
-@ FIXME: Could we avoid XFAIL to specify triple above?
-@ XFAIL: cygwin,mingw32,win32
-
         @ Make sure correct diagnostics are given for CPUs without support for
         @ one or other of the execution states.
         .thumb





More information about the llvm-commits mailing list