[PATCH] ARM: Form paired load after stack coloring.

[Renato Golin]

On 7 June 2013 01:00, Quentin Colombet <qcolombet at apple.com> wrote:

> - For ARM backend expert: Confirm that the value is not required. Or put
> differently, what was the purpose checking if  a value was set?
>

Hi Quentin,

What I think that line is checking is to make sure the value from the
operand is addressable, ie. there's something at the other end.

The comment above that condition is wrong, it should be below when it's
actually checking for the alignment, and that put me off for a while, but
now it's clear that this is just a sanity check, possibly introduced to fix
a bug somewhere where the load was being created when the dest was not
available, possibly breaking validation further down.

I don't claim to understand that part of the code, but would be good to
know why having a non-addressable "Value" makes your case work. It feels as
though the fix should be somewhere else...

cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130611/2b8a1f96/attachment.html>