[llvm] r183728 - Tweak a couple of tests on win32 hosts with +Asserts.

NAKAMURA Takumi geek4civic at gmail.com
Mon Jun 10 23:52:58 PDT 2013


Author: chapuni
Date: Tue Jun 11 01:52:58 2013
New Revision: 183728

URL: http://llvm.org/viewvc/llvm-project?rev=183728&view=rev
Log:
Tweak a couple of tests on win32 hosts with +Asserts.

  - Don't use assert(0), or tests may pass or fail according to assertions.
  - For now, The tests are marked as XFAIL for win32 hosts.

FIXME: Could we avoid XFAIL to specify triple in the RUN lines?

Modified:
    llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
    llvm/trunk/test/MC/ARM/arm-thumb-cpus-default.s
    llvm/trunk/test/MC/ARM/arm-thumb-cpus.s

Modified: llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp?rev=183728&r1=183727&r2=183728&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp (original)
+++ llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp Tue Jun 11 01:52:58 2013
@@ -681,7 +681,7 @@ MCAsmBackend *llvm::createARMAsmBackend(
   }
 
   if (TheTriple.isOSBinFormatCOFF())
-    assert(0 && "Windows not supported on ARM");
+    llvm_unreachable("Windows not supported on ARM");
 
   uint8_t OSABI = MCELFObjectTargetWriter::getOSABI(Triple(TT).getOS());
   return new ELFARMAsmBackend(T, TT, OSABI);

Modified: llvm/trunk/test/MC/ARM/arm-thumb-cpus-default.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/arm-thumb-cpus-default.s?rev=183728&r1=183727&r2=183728&view=diff
==============================================================================
--- llvm/trunk/test/MC/ARM/arm-thumb-cpus-default.s (original)
+++ llvm/trunk/test/MC/ARM/arm-thumb-cpus-default.s Tue Jun 11 01:52:58 2013
@@ -5,6 +5,9 @@
 @ RUN: llvm-mc -show-encoding -triple=armv7m < %s | FileCheck %s --check-prefix=CHECK-THUMB-ONLY
 @ RUN: llvm-mc -show-encoding -triple=armv6m < %s | FileCheck %s --check-prefix=CHECK-THUMB-ONLY
 
+@ FIXME: Could we avoid XFAIL to specify triple above?
+@ XFAIL: cygwin,mingw32,win32
+
         @ Make sure the architecture chosen by LLVM defaults to a compatible
         @ ARM/Thumb mode.
         movs r0, r0

Modified: llvm/trunk/test/MC/ARM/arm-thumb-cpus.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/ARM/arm-thumb-cpus.s?rev=183728&r1=183727&r2=183728&view=diff
==============================================================================
--- llvm/trunk/test/MC/ARM/arm-thumb-cpus.s (original)
+++ llvm/trunk/test/MC/ARM/arm-thumb-cpus.s Tue Jun 11 01:52:58 2013
@@ -5,6 +5,9 @@
 @ RUN: llvm-mc -show-encoding -triple=armv7m < %s 2>&1 | FileCheck %s --check-prefix=CHECK-THUMB-ONLY
 @ RUN: llvm-mc -show-encoding -triple=armv6m < %s 2>&1 | FileCheck %s --check-prefix=CHECK-THUMB-ONLY
 
+@ FIXME: Could we avoid XFAIL to specify triple above?
+@ XFAIL: cygwin,mingw32,win32
+
         @ Make sure correct diagnostics are given for CPUs without support for
         @ one or other of the execution states.
         .thumb





More information about the llvm-commits mailing list