[PATCH] Add host feature detection for Qualcomm CPUs

Tim Northover t.p.northover at gmail.com
Mon Jun 10 20:41:28 PDT 2013


>> It looks like the feature strings will be the same - and in fact we
>> grabbed them straight from the Linux kernel source which returns the same
>> strings for ARM-like CPUs (QC or ARM).
>
> I was unsure if the feature strings will be the same. However, I just looked
> into the Linux code and it seems it always emits the same feature strings
> for both targets. Here an updated patch.

So why are we checking the implementor at all? This whole code is
under #ifdef "__arm__" and "__linux__". Looking at Wikipedia there are
more ARM implementors to come, and I would be very surprised if Linux
picked a different set of feature names for them. (More surprised than
if they broke our code by renaming a feature, for example).

Cheers.

Tim.



More information about the llvm-commits mailing list