[polly] r183025 - Test that independent block pass does not transform induction variables

[Star Tan]

Hi Sebastian,


Thank you so much. 
Could you revise the new attachment and commit it?


Star Tan


At 2013-06-11 02:21:52,"Sebastian Pop" <spop at codeaurora.org> wrote:

>> +    Loop *L = LI->getLoopFor(entry);
>> +
>> +    if (L){
>
>Please add a space between ){
>
>Note that here you are testing for L not NULL...
>
>> +      if (!L->isLoopSimplifyForm())
>> +        INVALID(SimpleLoop, "Loop not in simplify form is invalid!");
>> +
>> +      for (pred_iterator PI = pred_begin(entry), PE = pred_end(entry); PI != PE;
>> +           ++PI) {
>> +        // Region entering edges come from the same loop but outside the region
>> +        // are not allowed.
>> +        if (L && L->contains(*PI) && !R.contains(*PI))
>
>... and here you are testing whether L is not NULL again: please
>remove this check here, as this is inside a loop.
>
>
>-- 
>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>hosted by The Linux Foundation
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130611/cfc2ca8f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ScopDetect-check-region-entering-edges-are-valid.patch
Type: application/octet-stream
Size: 5595 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130611/cfc2ca8f/attachment.obj>