[llvm] r183664 - Update for current naming conventions.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Jun 10 09:57:14 PDT 2013


On 10 June 2013 12:45, Chandler Carruth <chandlerc at google.com> wrote:
>
> On Mon, Jun 10, 2013 at 7:56 AM, Rafael Espindola
> <rafael.espindola at gmail.com> wrote:
>>
>> Update for current naming conventions.
>>
>> I will change identifyFileType to use a StringRef in the next patch.
>
>
> It seems much better to complete support in PathV2 and move clients to it
> than to continue updating PathV1.

I didn't find an equivalent in PathV2. In fact, now that
identifyFileType uses StringRef, can't we just move it to PathV2.h? If
I remember correctly the objective of the PathV1 to PathV2 transition
was to remove the Path class, which is not used by this function.

Cheers,
Rafael



More information about the llvm-commits mailing list