[lld] r183659 - Use early returns.
Rafael Espindola
rafael.espindola at gmail.com
Mon Jun 10 07:27:58 PDT 2013
Author: rafael
Date: Mon Jun 10 09:27:58 2013
New Revision: 183659
URL: http://llvm.org/viewvc/llvm-project?rev=183659&view=rev
Log:
Use early returns.
No functionality change.
Modified:
lld/trunk/lib/ReaderWriter/ELF/ELFTargetInfo.cpp
Modified: lld/trunk/lib/ReaderWriter/ELF/ELFTargetInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ELFTargetInfo.cpp?rev=183659&r1=183658&r2=183659&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/ELFTargetInfo.cpp (original)
+++ lld/trunk/lib/ReaderWriter/ELF/ELFTargetInfo.cpp Mon Jun 10 09:27:58 2013
@@ -98,16 +98,19 @@ ELFTargetInfo::parseFile(std::unique_ptr
std::vector<std::unique_ptr<File> > &result) const {
ScopedTask task(getDefaultDomain(), "parseFile");
error_code ec = _elfReader->parseFile(mb, result);
- if (ec) {
- // Not an ELF file, check file extension to see if it might be yaml
- StringRef path = mb->getBufferIdentifier();
- if (path.endswith(".objtxt"))
- ec = _yamlReader->parseFile(mb, result);
- if (ec)
- // Not a yaml file, assume it is a linkerscript
- ec = _linkerScriptReader->parseFile(mb, result);
+ if (!ec)
+ return ec;
+
+ // Not an ELF file, check file extension to see if it might be yaml
+ StringRef path = mb->getBufferIdentifier();
+ if (path.endswith(".objtxt")) {
+ ec = _yamlReader->parseFile(mb, result);
+ if (!ec)
+ return ec;
}
- return ec;
+
+ // Not a yaml file, assume it is a linkerscript
+ return _linkerScriptReader->parseFile(mb, result);
}
Writer &ELFTargetInfo::writer() const {
More information about the llvm-commits
mailing list