[PATCH] ARM: ISB options other than SY are reserved
Renato Golin
renato.golin at linaro.org
Mon Jun 10 06:50:54 PDT 2013
Hi Amaury,
Sorry for the delay, I think the patch looks good overall. The only
nit-pick I have is:
+ } else if (Tok.is(AsmToken::Hash) ||
+ Tok.is(AsmToken::Dollar) ||
+ Tok.is(AsmToken::Integer)) {
+ if (Parser.getTok().isNot(AsmToken::Integer))
+ Parser.Lex(); // Eat the '#'.
The comment is misleading, should be "eat # and $" or something like that.
Other than that, I'm happy with it.
cheers,
--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130610/697e9904/attachment.html>
More information about the llvm-commits
mailing list