[polly] [patch] [efficiency] Move getAliasSetForPointer under if (!IgnoreAliasing)
Tobias Grosser
tobias at grosser.es
Sun Jun 2 07:38:20 PDT 2013
On 06/02/2013 06:32 AM, Sebastian Pop wrote:
> Hi Dmitry,
>
> The patch looks good to me. Please allow Tobi to also comment on your patch
> before committing.
>
> Dmitry N. Mikushin wrote:
>> -static cl::opt<bool>
>> +cl::opt<bool>
>
> Why do you remove static here? Your change does not touch any other files.
>
>> IgnoreAliasing("polly-ignore-aliasing",
>> cl::desc("Ignore possible aliasing of the array bases"),
>> cl::Hidden, cl::init(false), cl::cat(PollyCategory));
>
>
> Also could you prepare a patch to disable AA with -polly-ignore-aliasing
>
> AA = &getAnalysisID<AliasAnalysis>(AliasAnalysis::getClassPassID());
>
> Please test and fix any other places using AA with -polly-ignore-aliasing.
>
> Also please add [polly] on the subject line on patches for polly.
I agree with Sebastian comments. After addressing them, the patch seems
good to go.
Tobi
More information about the llvm-commits
mailing list