[llvm] r182991 - X86: change MOV64ri64i32 into MOV32ri64

[Eric Christopher]

Hi Tim,

I've gone ahead and reverted this temporarily for you here:

Committing to https://llvm.org/svn/llvm-project/llvm/trunk ...
M lib/Target/X86/X86CodeEmitter.cpp
M lib/Target/X86/X86ISelDAGToDAG.cpp
M lib/Target/X86/X86InstrCompiler.td
M lib/Target/X86/X86MCInstLower.cpp
M test/CodeGen/X86/abi-isel.ll
Committed r183059

and it's logged as PR16192.

Thanks!

-eric


On Fri, May 31, 2013 at 3:32 PM, Joe Groff <arcata at gmail.com> wrote:
> +def MOV32ri64 : Ii32<0x88, AddRegFrm, (outs GR32:$dst), (ins
> i64i32imm:$src),
> +                     "", [], IIC_ALU_NONMEM>, Sched<[WriteALU]>;
> +
>
> This looks wrong. 0x88 isn't an AddReg opcode; 0x89, 0x8A, etc. are
> different opcodes:
>
> http://ref.x86asm.net/geek64.html#x88
>
> I'm seeing miscompiles in the JIT after this patch.
>
> -Joe
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>