[PATCH] [PECOFF][Writer] Implement the writer that can emit text section.
Shankar Kalpathi Easwaran
shankarke at gmail.com
Fri May 31 13:51:56 PDT 2013
================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:190
@@ +189,3 @@
+
+ llvm::object::data_directory _dirs[16];
+};
----------------
again, why public ?
================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:171
@@ +170,3 @@
+
+ llvm::object::pe32_header _peHeader;
+};
----------------
why _public ?
================
Comment at: lib/ReaderWriter/PECOFF/WriterPECOFF.cpp:86
@@ +85,3 @@
+ _dosHeader.Magic = 0x5a4d; // PE starts with the magic "MZ"
+ _dosHeader.AddressOfNewExeHeader = _size;
+ }
----------------
dont you want to do a memset here too ?
http://llvm-reviews.chandlerc.com/D892
More information about the llvm-commits
mailing list