[PATCH] [lsan] Run the leak checking tests under both ASan and LSan.

Alexey Samsonov samsonov at google.com
Fri May 31 05:58:29 PDT 2013


  LGTM


================
Comment at: lib/lsan/lit_tests/CMakeLists.txt:21
@@ -13,3 +20,3 @@
 
-if(COMPILER_RT_CAN_EXECUTE_TESTS)
+if(COMPILER_RT_CAN_EXECUTE_TESTS AND NOT APPLE AND NOT ANDROID)
   set(LSAN_TEST_DEPS
----------------
Sergey Matveev wrote:
> Alexey Samsonov wrote:
> > I'd prefer direct check that ${CMAKE_SYSTEM_NAME} STREQUAL "Linux"
> (NOT APPLE AND NOT ANDROID) is how Linux is defined in LSan and ASan CMake files, so we better replace it everywhere. Separate CL?
All right, let's leave it as is then.


http://llvm-reviews.chandlerc.com/D895

BRANCH
  feat/lsan/asan-tests

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list