[PATCH] Remove useless if from DwarfEHPrepare

Kai Nacke kai.nacke at redstar.de
Fri May 31 04:49:28 PDT 2013


Ping.

On 26.05.2013 17:20, Rafael EspĂ­ndola wrote:
> I think it is fine. It is basically a revert of 138605.
>
> Bill, what do you thinkL
>
> On 26 May 2013 06:46, Kai Nacke <kai.nacke at redstar.de> wrote:
>> Hi!
>>
>> In DwarfEHPrepare::InsertUnwindResumeCalls() there is a variable UsesNewEH
>> which has a default value of false and is set to true if the first
>> instruction after the unwind label of the last invoke in the function is a
>> landingpad instruction. This should always be the case.
>>
>> If there are no resume instructions then the value of UsesNewEH is returned
>> to the caller and used to indicate if the code has changed.
>>
>> To me, this looks like a relict from the time the EH mechanism was changed.
>> The attached patch removes the test and simply return false if nothing was
>> changed.
>>
>> Please review.
>>
>> Regards
>> Kai
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list