[PATCH] X86: Correct Defs for instructions that imp-def both an A-register and EFLAGS.

Jakob Stoklund Olesen stoklund at 2pi.dk
Wed May 29 12:38:36 PDT 2013


On May 29, 2013, at 11:59 AM, Ahmed Bougacha <ahmed.bougacha at gmail.com> wrote:

> Hi Jakob, all,
> 
> Title says all: this patch corrects a problem where x86 instructions
> that implicitly define both an A-register (RAX, EAX, ..) and EFLAGS
> were declared as only defining EFLAGS, because the outer
>  let Defs = [EFLAGS]
> in the various multiclasses overrides the
>  let Defs = [areg]
> in BinOpAI.
> 
> Add EFLAGS to BinOpAIs, and move all instances outside "let Defs”.

LGTM.

Is there a similar problem with the ‘Uses’ list and the SBC/ADC instructions?

/jakob





More information about the llvm-commits mailing list