[zorg] Add support for a new Aarch64 buildbot
Gabor Ballabas
gaborb at inf.u-szeged.hu
Wed May 29 09:08:02 PDT 2013
Hello Galina,
On 05/29/13 06:49, Galina Kistanova wrote:
> Hello Gabor,
>
> The patch looks Ok.
>
> There are two small things:
>
> > - configure_args = ["./configure"]
> > + configure_args = [WithProperties("%(builddir)s/" +
> "llvm/configure")]
> > + # configure_args = [WithProperties("%s/" + "llvm/configure",
> "builddir")]
>
> Why do you need the commented line?
>
Oops! Obviously that line is not needed at all. I've removed it.
> And for consistency with other builders, could you define llvm_srcdir
> (set it to "llvm" for in-tree or "llvm.src" for out-of-tree builds),
> and use it instead of hardcoded "llvm", please?
Done.
I attached the final versions of both patches.
Thanks for your help.
Best regards,
Gabor Ballabas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: outofdirv2.diff
Type: text/x-patch
Size: 3795 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130529/2da94cf4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: buildersandslavesv2.diff
Type: text/x-patch
Size: 1634 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130529/2da94cf4/attachment-0001.bin>
More information about the llvm-commits
mailing list