[PATCH] [nolibc] Add a test case for Linux/x86_64.
Alexey Samsonov
samsonov at google.com
Tue May 28 05:19:48 PDT 2013
LGTM with nits.
================
Comment at: lib/sanitizer_common/tests/sanitizer_nolibc_test_main.cc:15
@@ -14,5 +14,3 @@
-int main(int argc, char **argv) {
- testing::GTEST_FLAG(death_test_style) = "threadsafe";
- testing::InitGoogleTest(&argc, argv);
- return RUN_ALL_TESTS();
+#include <sanitizer_common/sanitizer_libc.h>
+
----------------
Why angular brackets here?
================
Comment at: lib/sanitizer_common/tests/CMakeLists.txt:106
@@ +105,3 @@
+ RTSanitizerCommon.test.nolibc.${arch}
+ LINK_FLAGS -nostdlib)
+ endif()
----------------
should you add ${TARGET_FLAGS} to link flags as well?
http://llvm-reviews.chandlerc.com/D873
BRANCH
has-weak
ARCANIST PROJECT
compiler-rt
More information about the llvm-commits
mailing list