[PATCH] [lsan] Convert the remaining LSan tests to output tests.

Sergey Matveev earthdok at google.com
Mon May 27 07:21:08 PDT 2013



================
Comment at: lib/lsan/lit_tests/large_allocation_leak.cc:12
@@ +11,3 @@
+  // maxsize in primary allocator is always less than this.
+  large_alloc = malloc(1 << 25);
+  fprintf(stderr, "Test alloc: %p.\n", large_alloc);
----------------
Kostya Serebryany wrote:
> Kostya Serebryany wrote:
> > use 33554432 ? 
> merge line 10 and 12?
done

================
Comment at: lib/lsan/lit_tests/use_stacks.cc:13
@@ +12,3 @@
+  void *stack_var;
+  stack_var = malloc(1337);
+  fprintf(stderr, "Test alloc: %p.\n", stack_var);
----------------
Kostya Serebryany wrote:
> merge two lines?
done

================
Comment at: lib/lsan/lit_tests/SharedLibs/huge_tls_lib_so.cc:1
@@ +1,2 @@
+//=-- huge_tls_lib_so.cc --------------------------------------------------===//
+//
----------------
Kostya Serebryany wrote:
> we don't put the license header in the tests
removed

================
Comment at: lib/lsan/lit_tests/SharedLibs/huge_tls_lib_so.cc:19
@@ +18,3 @@
+// space (see STATIC_TLS_SURPLUS in glibc).
+__thread void *huge_thread_local_array[(1 << 20) / sizeof(void *)]; // NOLINT
+
----------------
Alexander Potapenko wrote:
> Why there's a NOLINT here?
lint hates sizeof(type)


http://llvm-reviews.chandlerc.com/D870



More information about the llvm-commits mailing list