[PATCH] [lsan] Convert the remaining LSan tests to output tests.

Kostya Serebryany kcc at google.com
Mon May 27 07:01:04 PDT 2013



================
Comment at: lib/lsan/lit_tests/SharedLibs/huge_tls_lib_so.cc:1
@@ +1,2 @@
+//=-- huge_tls_lib_so.cc --------------------------------------------------===//
+//
----------------
we don't put the license header in the tests

================
Comment at: lib/lsan/lit_tests/large_allocation_leak.cc:12
@@ +11,3 @@
+  // maxsize in primary allocator is always less than this.
+  large_alloc = malloc(1 << 25);
+  fprintf(stderr, "Test alloc: %p.\n", large_alloc);
----------------
use 33554432 ? 

================
Comment at: lib/lsan/lit_tests/large_allocation_leak.cc:12
@@ +11,3 @@
+  // maxsize in primary allocator is always less than this.
+  large_alloc = malloc(1 << 25);
+  fprintf(stderr, "Test alloc: %p.\n", large_alloc);
----------------
Kostya Serebryany wrote:
> use 33554432 ? 
merge line 10 and 12?

================
Comment at: lib/lsan/lit_tests/use_stacks.cc:13
@@ +12,3 @@
+  void *stack_var;
+  stack_var = malloc(1337);
+  fprintf(stderr, "Test alloc: %p.\n", stack_var);
----------------
merge two lines?


http://llvm-reviews.chandlerc.com/D870



More information about the llvm-commits mailing list