[PATCH] [lsan] Convert all LSan tests to LIT tests. Remove the old testing interface.

Sergey Matveev earthdok at google.com
Fri May 24 08:22:41 PDT 2013


  Following our offline discussion, I'm starting with one LIT test. See D860.


================
Comment at: lib/lsan/lit_tests/use_tls_dynamic.cc:2
@@ +1,3 @@
+// RUN: LSAN_BASE="report_blocks=1:use_stacks=0:use_registers=0"
+// RUN: %clangxx_lsan -fno-sanitize=leak -fno-sanitize=address %p/SharedLibs/huge_tls_lib_so.cc -fPIC -shared -o %t-so.so
+// RUN: %clangxx_lsan %s -o %t
----------------
Kostya Serebryany wrote:
> Sergey Matveev wrote:
> > Kostya Serebryany wrote:
> > > Should this be something similar, like clangxx ? 
> > I'd agree if it was used more than once, but is it really worth creating an extra substitution just for this line? It's going to take several lines in the lit config.
> But using "%clangxx_lsan -fno-sanitize=leak -fno-sanitize=address %p/SharedLibs/huge_tls_lib_so.cc "
> looks even uglier. Please fix.
This is fixed in the new CL (this file is not included, but there's a substitution in the lit config).


http://llvm-reviews.chandlerc.com/D850



More information about the llvm-commits mailing list